Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Destination Timeplus: fix issues in README and upgrade timeplus and cdk #44758

Merged
merged 24 commits into from
Sep 8, 2024
Merged

✨ Destination Timeplus: fix issues in README and upgrade timeplus and cdk #44758

merged 24 commits into from
Sep 8, 2024

Conversation

jovezhong
Copy link
Contributor

What

Sorry I haven't upgraded the connector for a while. I found maybe the Airbyte engineer generated the docs as if it's a source. But it's destination connector. So I fixed those README issue, also added the run.py.

Updated the python SDK for Timeplus as well as CDK

How

Low risk change. Bump up the versions and updated README. I tested via poetry run destination-timeplus.., docker run, as well as airbyte-ci connectors --name=destination-timeplus test

Review guide

Please check run.py and pyproject.toml

User Impact

Better support latest version of Timeplus

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Aug 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 3:31am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 25, 2024
@jovezhong jovezhong temporarily deployed to community-ci-auto August 25, 2024 06:49 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto August 25, 2024 17:25 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto August 25, 2024 17:25 — with GitHub Actions Inactive
@jovezhong
Copy link
Contributor Author

The CI failed for Check if a review is required from Connector teams on fork with the following error. Let me know what I can do

write-review-requirements-file >> $GITHUB_OUTPUT
Traceback (most recent call last):
  File "/opt/pipx_bin/write-review-requirements-file", line 8, in <module>
    sys.exit(write_review_requirements_file())
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/connector_ops/required_reviewer_checks.py", line 58, in write_review_requirements_file
    mandatory_reviewers = find_mandatory_reviewers()
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/connector_ops/required_reviewer_checks.py", line 40, in find_mandatory_reviewers
    "is_required": utils.get_changed_metadata(diff_regex="upgradeDeadline"),
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/connector_ops/utils.py", line 99, in get_changed_metadata
    return get_changed_file(METADATA_FILE_NAME, diff_regex)
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/connector_ops/utils.py", line [12](https://github.com/airbytehq/airbyte/actions/runs/10548815955/job/29223151199?pr=44758#step:6:13)0, in get_changed_file
    for file_path in airbyte_repo.git.diff(*diff_command_args).split("\n")
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/git/cmd.py", line 986, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/git/cmd.py", line 1598, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/opt/pipx/venvs/connector-ops/lib/python3.10/site-packages/git/cmd.py", line [13](https://github.com/airbytehq/airbyte/actions/runs/10548815955/job/29223151199?pr=44758#step:6:14)88, in execute
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git diff --name-only -GupgradeDeadline origin/master
  stderr: 'fatal: ambiguous argument 'origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]''

@jovezhong jovezhong force-pushed the feature/refine-timeplus branch from 3b0eb9a to ea2e76f Compare August 28, 2024 04:20
@jovezhong jovezhong temporarily deployed to community-ci-auto August 28, 2024 04:21 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto August 28, 2024 04:21 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto September 4, 2024 01:04 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto September 4, 2024 01:04 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto September 5, 2024 18:03 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto September 5, 2024 18:04 — with GitHub Actions Inactive
marcosmarxm
marcosmarxm approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovezhong jovezhong temporarily deployed to community-ci-auto September 8, 2024 03:31 — with GitHub Actions Inactive
@jovezhong jovezhong temporarily deployed to community-ci-auto September 8, 2024 03:31 — with GitHub Actions Inactive
@jovezhong
Copy link
Contributor Author

LGTM

Hi @marcosmarxm , sorry after your approval and CI trigger, there was another automated build to bump up the dependency/version to 0.1.19. So I have to update the README/lock to 0.1.20. Please review again. If you approve, it'll be great if you can merge this to upstream. I am in PST and may not react fast enough. Thank you!

@marcosmarxm marcosmarxm merged commit 06f8a2b into airbytehq:master Sep 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/timeplus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jovezhong @marcosmarxm @octavia-squidington-iii